Fix time unit mixup in InstrumentedPool.PoolMetrics#isInactiveForMoreThan default implementation
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the units were mixed up and milliseconds were directly compared to seconds. Fixes #176.
violetagg
approved these changes
Sep 26, 2023
|
@reactor/team PTAL |
chemicL
reviewed
Sep 27, 2023
reactor-pool/src/test/java/reactor/pool/InstrumentedPoolPoolMetricsTest.java
Show resolved
Hide resolved
chemicL
reviewed
Sep 27, 2023
reactor-pool/src/test/java/reactor/pool/InstrumentedPoolPoolMetricsTest.java
Show resolved
Hide resolved
chemicL
reviewed
Sep 27, 2023
chemicL
requested changes
Sep 27, 2023
chemicL
approved these changes
Sep 27, 2023
violetagg
changed the title
InstrumentedPool.PoolMetrics default implementation
violetagg
changed the title
InstrumentedPool.PoolMetrics default implementationInstrumentedPool.PoolMetrics#isInactiveForMoreThan default implementation
|
@violetagg this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
violetagg
added a commit
that referenced
this pull request
Sep 27, 2023
freelon
deleted the
176-instrumentedPoolMetricsIsInactiveMixesTimeUnits
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the units were mixed up and milliseconds were directly compared to seconds.
Fixes #176.