-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROSADMIN] Add Mattermost plugin for admin panel #14
Conversation
485a306
to
d41359b
Compare
d41359b
to
2b3446a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts Stanislav and sorry for the long delay from my side!
Your PR looks good, just a few little things that need changing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, I have done suggested changes in a new commit.
7962b62
to
c539653
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I lack a suitable testing environment right now, but after reviewing the code in-depth, it should be fine to merge this particular PR and fix potentially outstanding production bugs afterwards.
Thanks for your efforts and sorry that the review took so long!
Requires a privileged token to work on all users.