Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROSADMIN] Add Mattermost plugin for admin panel #14

Merged
merged 3 commits into from
Mar 13, 2021

Conversation

binarymaster
Copy link
Member

  • Shows user sessions in Mattermost with detailed information
  • Allows to revoke specific or all user sessions

Requires a privileged token to work on all users.

@binarymaster binarymaster force-pushed the chat-admin branch 2 times, most recently from 485a306 to d41359b Compare December 13, 2020 00:20
Copy link
Member

@ColinFinck ColinFinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts Stanislav and sorry for the long delay from my side!
Your PR looks good, just a few little things that need changing.

www/www.reactos.org/roslogin/admin/Mattermost.php Outdated Show resolved Hide resolved
www/www.reactos.org/roslogin/admin/Mattermost.php Outdated Show resolved Hide resolved
www/www.reactos.org/roslogin/admin/pages/UserPage.php Outdated Show resolved Hide resolved
www/www.reactos.org/roslogin/admin/pages/UserPage.php Outdated Show resolved Hide resolved
Copy link
Member Author

@binarymaster binarymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, I have done suggested changes in a new commit.

Copy link
Member

@ColinFinck ColinFinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I lack a suitable testing environment right now, but after reviewing the code in-depth, it should be fine to merge this particular PR and fix potentially outstanding production bugs afterwards.

Thanks for your efforts and sorry that the review took so long!

@ColinFinck ColinFinck merged commit ca4f719 into reactos:master Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants