Improve await() to avoid unneeded futureTick() calls
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
force-pushed
the
the-future-is-now
branch
from
61dfe31
to
4d8331f
Compare
SimonFrings
approved these changes
Feb 18, 2022
This was referenced Feb 18, 2022
WyriHaximus
approved these changes
Feb 18, 2022
WyriHaximus
added a commit
to WyriHaximus-labs/async
that referenced
this pull request
Feb 20, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call.
```php
$promise = async(static function (): int {
echo 'a';
await(sleep(2));
echo 'b';
return time();
})();
$promise->cancel();
await($promise);
````
This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.
WyriHaximus
added a commit
to WyriHaximus-labs/async
that referenced
this pull request
Feb 21, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call.
```php
$promise = async(static function (): int {
echo 'a';
await(sleep(2));
echo 'b';
return time();
})();
$promise->cancel();
await($promise);
````
This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.
WyriHaximus
added a commit
to WyriHaximus-labs/async
that referenced
this pull request
Feb 21, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call.
```php
$promise = async(static function (): int {
echo 'a';
await(sleep(2));
echo 'b';
return time();
})();
$promise->cancel();
await($promise);
````
This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.
WyriHaximus
added a commit
to WyriHaximus-labs/async
that referenced
this pull request
Feb 24, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call.
```php
$promise = async(static function (): int {
echo 'a';
await(sleep(2));
echo 'b';
return time();
})();
$promise->cancel();
await($promise);
````
This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.
WyriHaximus
added a commit
to WyriHaximus-labs/async
that referenced
this pull request
Feb 24, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call.
```php
$promise = async(static function (): int {
echo 'a';
await(sleep(2));
echo 'b';
return time();
})();
$promise->cancel();
await($promise);
````
This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.
WyriHaximus
added a commit
to WyriHaximus-labs/async
that referenced
this pull request
Mar 2, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call.
```php
$promise = async(static function (): int {
echo 'a';
await(sleep(2));
echo 'b';
return time();
})();
$promise->cancel();
await($promise);
````
This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.
WyriHaximus
added a commit
to WyriHaximus-labs/async
that referenced
this pull request
Mar 3, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call.
```php
$promise = async(static function (): int {
echo 'a';
await(sleep(2));
echo 'b';
return time();
})();
$promise->cancel();
await($promise);
````
This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.
WyriHaximus
added a commit
to WyriHaximus-labs/async
that referenced
this pull request
Mar 3, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call.
```php
$promise = async(static function (): int {
echo 'a';
await(sleep(2));
echo 'b';
return time();
})();
$promise->cancel();
await($promise);
````
This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.
WyriHaximus
added a commit
to WyriHaximus-labs/async
that referenced
this pull request
Mar 4, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call.
```php
$promise = async(static function (): int {
echo 'a';
await(sleep(2));
echo 'b';
return time();
})();
$promise->cancel();
await($promise);
````
This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.
WyriHaximus
added a commit
to WyriHaximus-labs/async
that referenced
this pull request
Mar 4, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call.
```php
$promise = async(static function (): int {
echo 'a';
await(sleep(2));
echo 'b';
return time();
})();
$promise->cancel();
await($promise);
````
This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset improves the
await()function to avoid any unneededfutureTick()calls. This means we can now rely on its execution behavior just like all other promise functions and thecoroutine()function (#12) provided by this package.The
await()function is used to await the resolution of a promise in fiber-based asynchronous programs. Once the promise is fulfilled (or rejected), execution will now continue immediately. This is also in line with how thecoroutine()function continues execution immediately after ayieldstatement.In the previous version, this would have to await the next "loop tick" after the resolution which would be both unexpected from a consumer's perspective and slower in execution. The unexpected behavior has caused a number of issues in the past, most recently #27 which essentially boils down to multiple events happening in the same "tick" which is now supported just fine.
The test suite confirms this only adds new features not previously possible with the old approach and does not otherwise affect existing behavior. Affected code paths have 100% code coverage (I'll look into ensuring we have full code coverage also for unrelated code paths in a separate PR).
This changeset also promises some noticeable performance improvements in synthetic benchmarks, see also #31 for more details about benchmarks. Together with #30, I've seen some 25% performance improvements also inside Framework X for some use cases, but my main motivation is really avoiding unexpected behavior and solving related issues, so I do not expect a significant performance effect for most real-world applications.
I've kept my original commits and a final refactoring in place to ease reviewing and to show how I've gone about removing each group of ticks. The resulting code looks surprisingly straight-forward, but you're look at 8+ hours of work on this PR alone. Enjoy!
async()to avoid unneededfutureTick()calls #30 which applies the same changes for theasync()function. This PR can be considered a follow-up that concludes this entire feature.async()by making its promises cancellable #20 for future cancellation support, as afutureTick()can not be cancelled and we have to remember additional state in this case. With these changes, this is now no longer needed and we can simplify our upcoming cancellation logic.asyncandawaitfunctions #15 that originally introduced the fiber-basedawait()function.