Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test suite to add forward compatibility with PHPUnit 7, test against PHP 7.3 and use legacy PHPUnit 5 on legacy HHVM #122

Merged
merged 2 commits into from
Jan 30, 2019
Merged

Improve test suite to add forward compatibility with PHPUnit 7, test against PHP 7.3 and use legacy PHPUnit 5 on legacy HHVM #122

merged 2 commits into from
Jan 30, 2019

Conversation

clue
Copy link
Member

@clue clue commented Jan 29, 2019

Builds on top of #85 and clue/socket-raw#42

@clue clue added this to the v0.4.17 milestone Jan 29, 2019
@clue clue requested review from jsor and WyriHaximus January 29, 2019 18:08
@jsor jsor merged commit 47af7d6 into reactphp:master Jan 30, 2019
@clue clue deleted the phpunit branch January 30, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v0.4.17
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @jsor @WyriHaximus