Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dependency on ext-filter #185

merged 1 commit into from Nov 26, 2021


Copy link

@clue clue commented Nov 26, 2021

This simple changeset avoids an unneeded (and undeclared!) dependency on ext-filter. The extension is enabled by default, but can explicitly be disabled with --without-filter.

The code in question is already covered by the test suite, so the test suite confirms this changeset does not affect behavior or our public API in any way. Accordingly, this is entirely transparent for all consumers of this package, plus now also supports consumers that happen to use --without-filter.

Originally reported in leproxy/leproxy#80
Refs reactphp/socket#17

@clue clue added this to the v1.9.0 milestone Nov 26, 2021
Copy link
Member Author

clue commented Dec 6, 2021

For future reference only: The error suppression operator is no longer required for PHP 7.3+, see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants