Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on PHPUnit 9 and clean up test suite #212

Merged
merged 2 commits into from
Jul 19, 2020
Merged

Run tests on PHPUnit 9 and clean up test suite #212

merged 2 commits into from
Jul 19, 2020

Conversation

SimonFrings
Copy link
Member

@SimonFrings SimonFrings commented Jul 17, 2020 •
edited by clue
Loading

Builds on top of #209

clue
clue approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM 👍

@clue clue added this to the v1.2.0 milestone Jul 17, 2020
@clue clue requested review from WyriHaximus and jsor July 17, 2020 11:13
@jsor jsor merged commit 363a76d into reactphp:master Jul 19, 2020
@SimonFrings SimonFrings mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SimonFrings @jsor @WyriHaximus @clue