Improve documentation #240
Merged
+69
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a duplicate word ("the") from the comment for `LoopInterface::addPeriodicTimer`.
clue
reviewed
Oct 13, 2021
There was a problem hiding this comment.
@SimonFrings Thank you for looking into this and taking this over!
Most of the suggestions look good to me, what do you think about the documentation for the callback functions? (see also other callbacks)
SimonFrings
force-pushed
the
docs
branch
2 times, most recently
from
badd47c
to
af6d507
Compare
clue
approved these changes
Nov 12, 2021
WyriHaximus
approved these changes
Nov 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds on top of #227.
Thanks to @broberts-dev for putting the time into these changes!
I rearranged some commits and added a few improvements to the documentation.
Resolves and Closes #227.