Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test suite and report failed assertions #264

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

clue
Copy link
Member

@clue clue commented Feb 28, 2023

This changeset updates the test suite and makes sure we report any failed assertions as already discussed in reactphp/socket#299 and reactphp/socket#300.

In particular, we now test stable and "unstable" (or legacy) extensions separately (see also #250). Porting the test suite to latest versions was relatively straight forward, but you're also looking at several hours of work to make sure any legacy versions continue to work as is, yey! As discussed in #230, we may get rid of these legacy installations in the future and there's potential to significantly simplify this setup by installing extensions using the respective GitHub action instead (see also future plans for ReactPHP v3 as discussed in https://github.com/orgs/reactphp/discussions/481).

Builds on top of #258, #251, #250, #230, reactphp/socket#299 and reactphp/socket#300

@clue clue added this to the v1.4.0 milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants