Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Server to HttpServer to avoid class name collisions and ambiguities #417

Merged
merged 2 commits into from
Jul 27, 2021

Conversation

clue
Copy link
Member

@clue clue commented Jul 25, 2021

This changeset renames the Server class to HttpServer to avoid class name collisions and ambiguities.

// deprecated
$server = new React\Http\Server($handler);
$server->listen(new React\Socket\Server($port));

// new
$http = new React\Http\HttpServer($handler);
$http->listen(new React\Socket\Server($port));

The deprecated Server is now an alias for new HttpServer to ensure existing code continues to work as-is.

src/Server.php Outdated Show resolved Hide resolved
src/Server.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants