Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop leftover RingCentral PSR-7 dependency, use own PSR-7 implementation #522

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

clue
Copy link
Member

@clue clue commented Mar 26, 2024

This changeset drops the legacy RingCentral PSR-7 dependency and ensures we exclusively use our own PSR-7 implementation. This is the final step to replace the dated RingCentral implementation (#331) and allows us to eventually support PSR-7 v2 (#513). This is a purely internal change that comes with 100% code coverage and does not otherwise affect the public API, so it should be safe to apply.

To re-iterate: Our own Response, Request and ServerRequest classes continue to work just like in previous versions. In particular, this builds on top of the recent PSR-7 changes for the Response, Request, ServerRequest and Uri classes (#518, #519, #520, #521). Unlike these PRs, this changeset doesn't show a noticeable impact on performance during my benchmarks. As a consequence, I consider this mostly an internal optimization (cleanup) only.

Given this changeset does not otherwise affect our public API, this should be safe to apply. The test suite confirms this has 100% code coverage and does not otherwise affect our APIs. If you want to explicitly install this dependency, you can still install it like this:

composer require ringcentral/psr7

If you enjoy this change and want to help us continue to ship more improvements, consider supporting this project, for example by becoming a sponsor ❤️

Builds on top of #521, #520, #519, #518, #480, #432, #431, #370, #170 and others

@clue clue added this to the v1.10.0 milestone Mar 26, 2024
Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through all the changes, looks good to me 👍

Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉 🎉

Seriously hoping everyone using this package doesn't rely on it for providing RingCentrals PSR-7 package. Not looking forward to the potential support tickets. We should put this in the release notes, and add it to the social media messages we'll put out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants