Drop leftover RingCentral PSR-7 dependency, use own PSR-7 implementation #522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset drops the legacy RingCentral PSR-7 dependency and ensures we exclusively use our own PSR-7 implementation. This is the final step to replace the dated RingCentral implementation (#331) and allows us to eventually support PSR-7 v2 (#513). This is a purely internal change that comes with 100% code coverage and does not otherwise affect the public API, so it should be safe to apply.
To re-iterate: Our own
Response
,Request
andServerRequest
classes continue to work just like in previous versions. In particular, this builds on top of the recent PSR-7 changes for theResponse
,Request
,ServerRequest
andUri
classes (#518, #519, #520, #521). Unlike these PRs, this changeset doesn't show a noticeable impact on performance during my benchmarks. As a consequence, I consider this mostly an internal optimization (cleanup) only.Given this changeset does not otherwise affect our public API, this should be safe to apply. The test suite confirms this has 100% code coverage and does not otherwise affect our APIs. If you want to explicitly install this dependency, you can still install it like this:
If you enjoy this change and want to help us continue to ship more improvements, consider supporting this project, for example by becoming a sponsor ❤️
Builds on top of #521, #520, #519, #518, #480, #432, #431, #370, #170 and others