Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge SocketClient component into this component #74

Closed
clue opened this issue Feb 16, 2017 · 1 comment · Fixed by #87
Closed

Merge SocketClient component into this component #74

clue opened this issue Feb 16, 2017 · 1 comment · Fixed by #87

Comments

@clue
Copy link
Member

clue commented Feb 16, 2017

Here's the current situation:

  • This Socket component: Async, streaming plaintext TCP/IP and secure TLS socket server for ReactPHP
  • SocketClient component: Async, streaming plaintext TCP/IP and secure TLS socket client for ReactPHP

This is not exactly ideal, they share quite a bit of common code and actually have a dependency on one-another for their test suite.

Also, I believe this situation may be a bit confusing for consumers of this package. In particular our Datagram component provides both client and server side for datagram sockets (UDP).

As such, I'd vote for merging these two components into a single Socket component.

@clue
Copy link
Member Author

clue commented Mar 28, 2017

Deferred to future release as per #75. I'm working on getting this resolved this week :shipit:

clue added a commit to clue-labs/socket that referenced this issue Mar 29, 2017
Use `connect($uri)` instead of `create($host, $port)`
@clue clue closed this as completed in #87 Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant