Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/typo form #1341

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Fix/typo form #1341

merged 4 commits into from
Oct 16, 2023

Conversation

Angra974
Copy link
Contributor

Description

The form for creating a play works well.
Nevertheless, we use MUI to desing our application and a typo in the code didn't let use get the best benefice from it.

This PR is to correct it.

Fixes #1340

Type of change

Replacing

       label={field.plaeholder}

by the good spelling

       label={field.placeholder}
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small correction that didn't need to update the documentation and do no breaking change

How Has This Been Tested?

On localhost,

  • display the form before change and test his rendering with input data
  • display the form adter change and test his rendering with input data

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Just use the form used to create a play without change,
and after change.

Before change can be viewed on reactplay.io
After change can be viewed on this netlify deploy

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

video here

As my pc is slow, check the 30st seconds in the video for before change,
the 30 second at the end for after change.

I didn't take time to edit the video as i'm on Ubuntu now and don't have my usual tools.

@netlify
Copy link

netlify bot commented Oct 15, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 6ba8dd4
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/652c17958c0588000874434a
😎 Deploy Preview https://deploy-preview-1341--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@atapas atapas merged commit dbe521b into main Oct 16, 2023
4 of 6 checks passed
@atapas atapas deleted the fix/typo_form branch October 16, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Correct a typo for the create play form
3 participants