Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Back Button in Pokemon-Stats #646

Merged
merged 10 commits into from
Oct 28, 2022

Conversation

GodStarLord
Copy link
Contributor

Description

After the user searches for a Pokemon, to search for another pokemon, the user needs to reload the pokemon-stats causing bad user experience. Added back button which takes the user to the initial search UI

Type of change

✔️: Enhancement

Added back button which takes the user to the initial search UI
@vercel
Copy link

vercel bot commented Oct 8, 2022

@GodStarLord is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 6:52PM (UTC)

@atapas
Copy link
Member

atapas commented Oct 13, 2022

@GodStarLord Where is the issue? Please add the issue and link it to the PR for the review to start.

@GodStarLord
Copy link
Contributor Author

Hi @atapas, I have created the issue #689 for this pull request.

@GodStarLord
Copy link
Contributor Author

Issue #689 - Need to reload the play
msedge_mTSA9qn04H

Resolution provided in this pull request #646
Added back button, no need to reload the play
msedge_iAtVdgvhFB

@GodStarLord
Copy link
Contributor Author

resolved the conflicts due to file changes in the Pokemon-stats play from .jsx to .tsx

Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GodStarLord
Copy link
Contributor Author

@atapas can you please do the code review?

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@atapas atapas added the hacktoberfest-accepted hacktoberfest-accepted label Oct 28, 2022
@atapas atapas merged commit 579805d into reactplay:main Oct 28, 2022
@GodStarLord GodStarLord deleted the enhance-pokemon-stats-app branch November 3, 2022 09:31
@GodStarLord GodStarLord restored the enhance-pokemon-stats-app branch November 3, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Enhancement]: Add back button in pokemon-stats play search details UI
3 participants