Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tenzies Games #841

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Added Tenzies Games #841

merged 2 commits into from
Dec 23, 2022

Conversation

AbhiPatel10
Copy link
Contributor

It's Roll dice game Where all Dice should be same, Click each die to freeze it at its current value between rolls.

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #840

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Screenshot 2022-12-22 110350

It's Roll dice game Where all Dice should be same, Click each die to freeze it at its current value between rolls.
@vercel
Copy link

vercel bot commented Dec 22, 2022

@AbhiPatel10 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 😊.
Please reference the issue number in the description if you are fixing a bug.
If you are implementing a feature request, please check with the maintainers that the feature will be accepted first.
Stale Marking : After 30 days of inactivity this PR will be marked as stale PR and it will be closed and locked in 7 days if no further activity occurs.

@vercel
Copy link

vercel bot commented Dec 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-play ✅ Ready (Inspect) Visit Preview 1 resolved Dec 23, 2022 at 9:10AM (UTC)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbhiPatel10 A few comments

src/plays/tenzies-game/Readme.md Outdated Show resolved Hide resolved
src/plays/tenzies-game/Readme.md Outdated Show resolved Hide resolved
src/plays/tenzies-game/styles.css Outdated Show resolved Hide resolved
…Update] Style Class name

I have added all about my game tenzies into readme file, also add Implementation on it.

Style class name changed.
@AbhiPatel10
Copy link
Contributor Author

@atapas sir, I have updated readme and style file as you say above, please check and let me know if it's good or need to change anything.

Thank you :)

@atapas
Copy link
Member

atapas commented Dec 23, 2022

@atapas sir, I have updated readme and style file as you say above, please check and let me know if it's good or need to change anything.

Thank you :)

Changes are looking good to me. I shall do a final test and merge it.

@atapas
Copy link
Member

atapas commented Dec 23, 2022

It works well

image

@atapas atapas merged commit b54608d into reactplay:main Dec 23, 2022
@AbhiPatel10
Copy link
Contributor Author

Thanks a lot sir for approving my PR, Looking forward to contribute more in reactplay. I love it....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add a Play]: Tenzies Game
2 participants