Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added The Play not found feature #94

Merged
merged 3 commits into from
Apr 23, 2022
Merged

Conversation

hasnainmakada-99
Copy link
Contributor

@hasnainmakada-99 hasnainmakada-99 commented Apr 22, 2022

Description

Added The play not found feature in the search functionality, Now whenever the user will search for a play which is not there it will throw the play not found messsage

Fixes # 43

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

npm start

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Apr 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/atapas/react-play/6JzRStVkXPMcN1idjSsNsMUSZsYq
✅ Preview: https://react-play-git-fork-hasnainmakada-99-hasnain-atapas.vercel.app

src/common/playlists/PlayList.jsx Outdated Show resolved Hide resolved
src/common/playlists/PlayList.jsx Outdated Show resolved Hide resolved
@hasnainmakada-99
Copy link
Contributor Author

@atapas sir i've made the changes you told me

src/common/playlists/PlayList.jsx Outdated Show resolved Hide resolved
src/common/playlists/PlayList.jsx Outdated Show resolved Hide resolved
@atapas atapas merged commit 718e21e into reactplay:main Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Show no play found when there is no match for filter and search result
2 participants