Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2PlaysAMonth]: Random Quote Card Generator #957

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

PriteshKiri
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Feb 11, 2023

@PriteshKiri is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 😊.
Please reference the issue number in the description if you are fixing a bug.
If you are implementing a feature request, please check with the maintainers that the feature will be accepted first.
Stale Marking : After 30 days of inactivity this PR will be marked as stale PR and it will be closed and locked in 7 days if no further activity occurs.

@vercel
Copy link

vercel bot commented Feb 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-play ✅ Ready (Inspect) Visit Preview 1 resolved Feb 12, 2023 at 3:28AM (UTC)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriteshKiri Could you please record a stream as well on stackstream and add the video link by editing your play?

@PriteshKiri
Copy link
Contributor Author

@PriteshKiri Could you please record a stream as well on stackstream and add the video link by editing your play?

Yes, @atapas

Just recorded a stream on stackstream and updated the link on my play's profile. I hope the stream is recorded well. Please let me know if I have to change anything. Sharing the link here as well for quick navigation:

Link of my Stackstream: https://www.stack-stream.com/v/random-quote-card-generator-2playsamonth-reactplay-io

@atapas
Copy link
Member

atapas commented Feb 12, 2023

@PriteshKiri Could you please record a stream as well on stackstream and add the video link by editing your play?

Yes, @atapas

Just recorded a stream on stackstream and updated the link on my play's profile. I hope the stream is recorded well. Please let me know if I have to change anything. Sharing the link here as well for quick navigation:

Link of my Stackstream: https://www.stack-stream.com/v/random-quote-card-generator-2playsamonth-reactplay-io

Thank You!

The recording looks great.

@PriteshKiri
Copy link
Contributor Author

@PriteshKiri Could you please record a stream as well on stackstream and add the video link by editing your play?

Yes, @atapas
Just recorded a stream on stackstream and updated the link on my play's profile. I hope the stream is recorded well. Please let me know if I have to change anything. Sharing the link here as well for quick navigation:
Link of my Stackstream: https://www.stack-stream.com/v/random-quote-card-generator-2playsamonth-reactplay-io

Thank You!

The recording looks great.

Awesome!

Looking forward for the merge so that I can share in on my socials :)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriteshKiri Great Job!

I loved it as I completed my test on it. We will merge it, and the play will go LIVE in a few minutes.

Please continue to build the second one :)

Also, feel free to talk about your first play contribution to the world as part of the #2PlaysAMonth challenge and while you do so, don't forget to tag ReactPlay and post a hashtag #2PLaysAMonth.

Thanks!

@atapas atapas merged commit 20ece69 into reactplay:main Feb 12, 2023
@PriteshKiri
Copy link
Contributor Author

@PriteshKiri Great Job!

I loved it as I completed my test on it. We will merge it, and the play will go LIVE in a few minutes.

Please continue to build the second one :)

Also, feel free to talk about your first play contribution to the world as part of the #2PlaysAMonth challenge and while you do so, don't forget to tag ReactPlay and post a hashtag #2PLaysAMonth.

Thanks!

Thank you so much @atapas !

Will surely share this on my socials once the link goes live 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants