Replies: 75 comments 216 replies
-
|
Small heads up that this is coming inside 0.72 (inside the CLI): It's a breaking change but I don't expect anyone to be impacted by this change. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
Also to clarify, 0.72 is going to be shipped with Flipper 0.182.0 which is the last known version to not be affected by this, so that's probably not a release blocker. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
Beta Was this translation helpful? Give feedback.
-
|
I tried investigating that but looks like ReactActivityDelegate isn't the one dealing with this @cortinico, if we look closely, this So potentially, this ReactRootView's I am still looking for the root cause of this issue 👀 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for reporting this @tomekzaw and for investigating @hurali97 This must be picked in RC1 as it's quite of an important fix |
Beta Was this translation helpful? Give feedback.
-
|
@tomekzaw RC1 should fix this - let us know! |
Beta Was this translation helpful? Give feedback.
-
|
@kelset It works for me, thanks for the fix @cortinico! |
Beta Was this translation helpful? Give feedback.
-
|
I'm getting a crash on startup on Android: It looks like the window isn't yet attached or something. We are getting a
|
Beta Was this translation helpful? Give feedback.
-
|
RC1 is out which should have fixed this issue – @tido64, could you please try it and let us know if you still see the issue? |
Beta Was this translation helpful? Give feedback.
-
|
This still happens with RC1. Repro steps: |
Beta Was this translation helpful? Give feedback.
-
|
I've some some investigation, and the crash disappears if you remove this line: Sadly being the crash inside RNTA makes hard for me (or others) to investigate what's going on. Having a repro coming from the default template would help to debug further. |
Beta Was this translation helpful? Give feedback.
-
|
@tido64 anything you can do from your side related to this? 👆 we're starting to get closer to golden RC status so better understanding the gravity of this issue would help make the right call. |
Beta Was this translation helpful? Give feedback.
-
|
This being an edge case (you basically have to override |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
Will be fixed in facebook/react-native#36571 |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
RC1 with the fix is out, @hurali97 can you confirm you no longer see the issue? |
Beta Was this translation helpful? Give feedback.
-
|
Hey @fortmarek ! Yes I tested out by creating a new 0.72.0-rc.1 app and I don't see those files anymore in root. 🎉
|
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
facebook/react-native@eb83356 merged this (FYI @kelset). Would be good to get into next RC since it blocks updating RN version on docs site. |
Beta Was this translation helpful? Give feedback.
-
|
yup 👍 already in the list 👍 |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
thanks Sam - picked in branch |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
will these be cherry picked into v71 as well? thanks |
Beta Was this translation helpful? Give feedback.
-
|
not right away - we'll first put them into the next 72 RC, wait for feedback and then put them into 0.71-0.70-0.69 once we have more confidence that they address the problem. |
Beta Was this translation helpful? Give feedback.
-
|
thanks, we might then upgrade to 72 to test its effectiveness, if third party libraries don't require updating to support it 🤞 |
Beta Was this translation helpful? Give feedback.
-
|
(picked in 0.72 branch) |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
picked in branch |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
picked in branch |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
Yup it's already present. |
Beta Was this translation helpful? Give feedback.
-
Are you sure? I see facebook/react-native@c5a47ab updates https://github.com/facebook/react-native/blob/0.72-stable/packages/metro-config/package.json#L3 This is the reason why we have failing CircleCI tests on |
Beta Was this translation helpful? Give feedback.
-
|
the changes you are asking about @hoxyq were done here: facebook/react-native@9ffe82e but yeah that metro config version misalignment is concerning 😱 was 0.72.1 generated/versioned in main branch only? 😰 |
Beta Was this translation helpful? Give feedback.
-
|
I've dug a bit more, it might be easy to address - and realign 0.72-stable to use latest metro config. We are lucky that the changes were minimal. |
Beta Was this translation helpful? Give feedback.
-
|
should be addressed by facebook/react-native#36746 - lmk |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
yeah, currently RC.0 is broken due to some misconfiguration of the CLI and Metro. We are working on fixing it for RC.1. |
Beta Was this translation helpful? Give feedback.
-
|
@shamilovtim this should be fixed in RC1 that is out now, could you confirm you no longer see the issue? 🙏 |
Beta Was this translation helpful? Give feedback.
-
|
Fixed, thank you |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
-
|
picked in branch |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
We found the root cause of it and we are working on a fix. |
Beta Was this translation helpful? Give feedback.
-
|
Resolved and picks are requested in #54 (comment) |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
Fixed by upgrading reanimated: facebook/react-native#37639 (comment) |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
A quote is missing : |
Beta Was this translation helpful? Give feedback.
-
|
Oh yeah sorry, I just wrote that from memory. I added that correctly to the project when doing the test upgrade :D But that is not the issue I am trying to raise. The issue is that I have to add that line to my podfile that which was not needed before. I could imagine that more people will run into that problem when upgrading to 0.72. |
Beta Was this translation helpful? Give feedback.
-
|
Hey @AlexanderEggers! Can you reproduce this also in the project created via @cipolleschi any idea what's going on here? |
Beta Was this translation helpful? Give feedback.
-
|
Hi @AlexanderEggers, thanks for the report. We haven't changed anything specific on how the configurations are handled. But I think Cocoapods released a couple of versions which may influence that. If you could provide a repro, as @fortmarek suggested, it would be very helpful for us. We do not handle special configurations in the Template, so a repro can give us something concrete on which we can investigate. |
Beta Was this translation helpful? Give feedback.
-
|
Edit: @fortmarek @cipolleschi - Apologies I found my issue that happened during the migration to 0.72.. due to the significant changes in the podfile of 0.72.0, I missed adding the custom configurations to
|
Beta Was this translation helpful? Give feedback.
-
|
0.72.0-rc.4/rc.5 breaks react-native-reanimated integration on iOS/Paper, rc.3 was fine though: |
Beta Was this translation helpful? Give feedback.
-
|
For all early adopters, here's a working patch:
We're still considering other approaches. |
Beta Was this translation helpful? Give feedback.
-
|
@cortinico ✅ Support for 0.72 added in react-native-reanimated@3.3.0. |
Beta Was this translation helpful? Give feedback.
-
|
Amazing stuff @tomekzaw, you folks rock! |
Beta Was this translation helpful? Give feedback.
-
|
0.72.0-rc.4/rc.5 requires some changes in react-native-screens on Android/Fabric, rc.3 was fine though: |
Beta Was this translation helpful? Give feedback.
-
|
I'm running into this as well. |
Beta Was this translation helpful? Give feedback.
-
|
Commented on the issue, I can support on this one if we find the root cause. |
Beta Was this translation helpful? Give feedback.
-
|
@cortinico ✅ Support for 0.72 added in react-native-screens@3.21.0 by @WoLewicki |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
Those issues are still opened, so I'd say it's expected that the regression is in 0.72 as well. We will do a patch as soon as fix is merged to
Can you provide reproduction steps or a reproduction sample? 🙏 |
Beta Was this translation helpful? Give feedback.
-
|
@cortinico The regression was at the first place present in 0.71 also, and same was continued in 0.72. That's why thought of mentioning it here. @fortmarek Sure. Ours is a complex app, and it won't be able to share the complete code here as a reproduction sample. Will try to reproduce it on a simpler project and share the sample. Thank you for responding. |
Beta Was this translation helpful? Give feedback.
-
Given that the regression is already there in 0.71, this is not the right place to report it as we can't really actionate it. Let's follow up on the GitHub issues that got already reported. |
Beta Was this translation helpful? Give feedback.
-
|
I fear the perf degradation will migrate to 0.72. I hope 0.72 won't have this crucial performance issues I'm experiencing within 0.71. |
Beta Was this translation helpful? Give feedback.
-
|
let's keep the performance regression conversation in those linked issues. And for the other "report" (B) please open a dedicated issue with a repro, as Nicola mentioned, it's very hard to understand what's going on here. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
I think we should be able to cherry pick it for 0.72 – either in the next RC if we do one (which hopefully won't be the case) or we will follow up with 0.72.1. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
Do we have a separate task for upgrading Boost to a version that doesn't use |
Beta Was this translation helpful? Give feedback.
-
|
I have to ask around internally. My understanding is that bumping Boost is a major pain and creates a lot of headaches. From a quick search in the OSS repo, no c++ code is using boost directly. |
Beta Was this translation helpful? Give feedback.
-
|
Had a quick look. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
just throwing there my current reasoning: if it's a quick fix and we can get the commit ready asap, let's do 0.72.0 without it and 0.72.1 like 24hrs later with the fix + the other commits that have been requested. |
Beta Was this translation helpful? Give feedback.
-
The changes could also be reverted atomically if we are not able to come to a fix. |
Beta Was this translation helpful? Give feedback.
-
|
I hope that the folks you pinged in the issue will be able to give us insights into what it takes for fixing. But yeah, worst case we'd revert. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
12.0.0-alpha.4, v11.3.2 and v10.2.4 have been published: react-native-community/cli#1957 (comment) |
Beta Was this translation helpful? Give feedback.
-
|
11.3.2 is the one we want for 72 -> https://github.com/react-native-community/cli/commits/11.x |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
yep, this is blocking for the interop layer (and my bad). Thanks again @gabrieldonadel! Probably will land Monday afternoon. |
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
sidenote: it sounds like this is new arch specific and there might be workarounds viable, so it's not necessarily a blocker for 0.72.0 |
Beta Was this translation helpful? Give feedback.
-
|
Yup that's New Arch specific, also I've confirmed this is a bug. Fix is incoming in the next hours. If picked for the next RC, this will also need a bump of |
Beta Was this translation helpful? Give feedback.
-
|
Fix is here: |
Beta Was this translation helpful? Give feedback.
-
|
@jankosecki RC6 is out and contains the fix, can you let me know if everything's working now? |
Beta Was this translation helpful? Give feedback.
-
|
@kelset Yes, I can confirm that both android and ios build fine now. Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
@kelset @cortinico i get this Failure Error in IOS when i make use of this unstable_reactLegacyComponentNames: ['BVLinearGradient'] to support in new architecture Thread Performance Checker: Thread running at QOS_CLASS_USER_INTERACTIVE waiting on a lower QoS thread running at QOS_CLASS_DEFAULT. Investigate ways to avoid priority inversions Assertion failed: (module), function constructCoordinator, file LegacyViewManagerInteropComponentDescriptor.mm, line 64. |
Beta Was this translation helpful? Give feedback.
-
|
please open a dedicated issue for this problem and add a link here |
Beta Was this translation helpful? Give feedback.
-
|
Yup please report an issue as @kelset suggested + this is an |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
This comment has been hidden.
This comment has been hidden.
-
|
Please open a dedicated issue for this problem with a proper description and add a link here. Thanks :) |
Beta Was this translation helpful? Give feedback.
-
|
On 0.72.0-rc6 (using New Architecture) I am having Text style issue. <Text style={{ color: someStateValue ? 'blue' : 'orange' }}This isn't working when I think this issue is only for iOS only issue. |
Beta Was this translation helpful? Give feedback.
-
|
Can you show a more complete example in how |
Beta Was this translation helpful? Give feedback.
-
const [colorValue, setColorValue] = useState<string>('blue');
return (
<View
style={{ justifyContent: 'center', alignItems: 'center', flex: 1 }}>
<Button
title="Change Color"
onPress={() => setColorValue('orange')}
/>
<Text style={{ color: colorValue }}>Hello</Text>
</View>
) |
Beta Was this translation helpful? Give feedback.
-
|
thanks for reporting! since it's new arch, and new arch is still experimental, could you open a dedicated issue in the main repo so that it can be tracked there? (similarly to facebook/react-native#37905) |
Beta Was this translation helpful? Give feedback.
-
|
@kelset |
Beta Was this translation helpful? Give feedback.
-
|
this will fix Text component cache issue. |
Beta Was this translation helpful? Give feedback.
-
|
Can we pick facebook/react-native#37922 into the next release? |
Beta Was this translation helpful? Give feedback.
-
|
cc again, @huntie |
Beta Was this translation helpful? Give feedback.
-
|
based on what @tido64 is saying, it looks like this would force folks to update to Xcode 14.3 so technically it'd be a breaking change... we need to be careful. |
Beta Was this translation helpful? Give feedback.
-
|
for further details, check out the conversation here -> #73 (comment) |
Beta Was this translation helpful? Give feedback.
and others
-
Released, please refer to #74
The branch cut has happened on this commit.
Notice
Highlighted Changes in this release
Rough list of main changes (unordered, unprioritized)
unstable_reactLegacyComponentNamesto iOS project config react-native-community/cli#1859unstable_reactLegacyComponenttocli-platform-androidreact-native-community/cli#1849For more details, checkout the Changelog PR
Release Process
Checklist
react-native-websitewith the new version cut (see docs) Generate 0.72 version of the docs facebook/react-native-website#3770Retrospective Topics
Release Status
Blocking issues for releasing 0.72.1 / 0.72.0-rc.7
getEventDatasoftware-mansion/react-native-screens#1778Picks for 0.72.1 / 0.72.0-rc.7
npx react-native@latest init <AppName>facebook/react-native#37521Modalonly once on Android facebook/react-native#35803react-test-rendereris not a runtime dependency facebook/react-native#37955pod install --project-directory=iosfailing facebook/react-native#37994Tracking 0.72.0-rc.6 (released ✅)
Blocking issues for releasing 0.72.1 / 0.72.0-rc.6
Picks for 0.72.1 / 0.72.0-rc.6
(lower prior, can wait after current)
Tracking 0.72.0-rc.5 (released ✅)
Picks for 0.72.0-rc.5
@react-native/gradle-pluginTracking 0.72.0-rc.4 (released ✅)
Tracking 0.72.0-rc.4
Issues reported / blocking releasing 0.72.0-rc.4
Android crash: link to commentunstable_enablePackageExportsbroken with new projectPicks for 0.72.0-rc.4
(local 0.72-stable PRs)
v11.3.0in0.72-stablefacebook/react-native#37467(cherry-picks)
Content-Locationheader in bundle response as JS source URL facebook/react-native#37501hermescfacebook/react-native#37531npx react-native@latest init <AppName>facebook/react-native#37521//# sourceURL,Content-Locationfacebook/metro#989Tracking 0.72.0-rc.3 (released ✅)
Mandatory pre 0.72.0 tasks
Tracking 0.72.0-rc.3
Issues reported / blocking releasing 0.72.0-rc.3
Picks for 0.72.0-rc.3
Tracking 0.72.0-rc.2 (released ✅)
Tracking 0.72.0-rc.2
Blocking issues for releasing 0.72.0-rc.2
Picks for 0.72.0-rc.2
Tracking 0.72.0-rc.1 (released ✅)
Blocking issues for releasing 0.72.0-rc.1
Picks for 0.72.0-rc.1
already picked in branch
pre-branch cut tracking list
Discuss/address/decide/complete
Mandatory pre-cut
Geometry.hinreact/renderer/graphicsto reduce the breaking changes @cipolleschiunstable_reactLegacyComponentNamesto iOS project config react-native-community/cli#1859unstable_reactLegacyComponenttocli-platform-androidreact-native-community/cli#1849Mandatory pre-stable 0.72.0
Optional
use_frameworkssupport on iOS (new arch)0.71.1facebook/react-native#35930For 0.73+
inlineRequiresas false in templateRNTester: Setup E2E tests for iOS and Android with Appium and Jest facebook/react-native#35016Pressable? time to default to it?react-native-flipper0.171 and up are causing linking errors on iOS Release build facebook/flipper#4457Confirmed/finished/done
Beta Was this translation helpful? Give feedback.
All reactions