Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio tag inside the p element not rendering #156

Closed
mrifni opened this issue Feb 16, 2021 · 8 comments
Closed

Audio tag inside the p element not rendering #156

mrifni opened this issue Feb 16, 2021 · 8 comments
Labels
bug Something isn't working

Comments

@mrifni
Copy link
Contributor

mrifni commented Feb 16, 2021

So this sample tag doesnt render but renders an empty white space in the latest test app build.

<p class="calibre1"><b class="calibre2">ʺAnd donʹt pursue (say) that of which you have no knowledge (of).ʺ </b>[Sooratul-Israa, 17:36]<p><audio src="https://cdn.islamic.network/quran/audio/128/ar.alafasy/2065.mp3" controls="controls">Audio not supported!</audio></p></p>

Screenshot 2021-02-16 at 09 44 19

I have sent the sample EPUB via slack.

@mickael-menu mickael-menu added the bug Something isn't working label Feb 16, 2021
@mickael-menu
Copy link
Member

Note to self: shared EPUB is named 0fdf1bffb52048bd849afa7cf698c4c1_sample.epub

@JayPanoz
Copy link

@mickael-menu
Copy link
Member

@mickael-menu see readium/readium-css#100

Thanks, that may be related. The audio elements don't have auto width but this is the stylesheet:

audio {
    -webkit-box-shadow:  2px 2px 4px 0px #006773;
    box-shadow: 2px 2px 4px 0px #006773;
    -moz-border-radius:25px;
    -webkit-border-radius:25px;
    border-radius:25px;
}

@mrifni
Copy link
Contributor Author

mrifni commented Feb 16, 2021

so I have tested by putting width="auto" height="auto" in the epub file and still it didnt render the audio tag for me.

<p><audio src="https://cdn.islamic.network/quran/audio/128/ar.alafasy/1268.mp3" controls="controls" width="auto" height="auto">Audio not supported!</audio></p>

@JayPanoz
Copy link

No I meant this is a known issue in fallback styles of Readium CSS (auto appearing to make the controls invisible) but the fix wasn’t PR’d yet.

If you put something like this in your CSS, does it solve the issue by any chance?

audio {
  width: 100%;
  height: 2em;
}

@mrifni
Copy link
Contributor Author

mrifni commented Feb 16, 2021

it does work but there is a small issue. When I press the 3 dots at the end of the audio player ( next to the mute button ) page moves to middle of two pages.

Before click

After click

@danielweck
Copy link
Member

FYI, this is how we work around this ReadiumCSS bug in Thorium: readium/readium-css#94 (comment)

@mickael-menu
Copy link
Member

Thanks @danielweck, that fixed the issue!

@mickael-menu mickael-menu transferred this issue from readium/r2-navigator-kotlin Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants