Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: Debian package works (unlike AppImage), but no top-level menu unless reader view open #18

Closed
danielweck opened this issue Jan 16, 2019 · 3 comments

Comments

@danielweck
Copy link
Member

This in itself is not a big deal, but what is more annoying is that the small "open publication" dialog does not have a "exit" option, so it requires CTRL-C to shutdown!!

  1. Download r2-testapp-js_1.0.6-0_amd64.deb from https://github.com/readium/r2-testapp-js/releases/tag/latest-linux
  2. sudo apt-get install ./r2-testapp-js_1.0.6-0_amd64.deb
  3. r2-testapp-js
@danielweck
Copy link
Member Author

Related issue: #17

@danielweck
Copy link
Member Author

Same problem in Windows.

@danielweck
Copy link
Member Author

Fixed by adding the missing top-level menu, and more importantly by adding a confirmation dialog to exit the app (same logic on MacOS, Linux and Windows to make things simple, although conventionally there is a different behaviour on MacOS because of the persistent window-less top-level menu ... but this is fine for a test app)
55a341d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant