Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font face case discrepancies, Accessible DFA vs. Dfa (and DfA ;) #35

Closed
danielweck opened this issue Mar 5, 2018 · 6 comments
Closed

Font face case discrepancies, Accessible DFA vs. Dfa (and DfA ;) #35

danielweck opened this issue Mar 5, 2018 · 6 comments

Comments

@danielweck
Copy link
Member

AccessibleDFA should be AccessibleDfa:

readium-css/css/dist/ReadiumCSS-after.css

Line 676 in edfdc2a

font-family: AccessibleDFA, Verdana, Tahoma, "Trebuchet MS", sans-serif !important;

readium-css/css/dist/ReadiumCSS-before.css

Line 310 in edfdc2a

font-family: AccessibleDfa;

(the file itself is AccessibleDfA, but that's alright ;)
JayPanoz added a commit that referenced this issue Mar 5, 2018
@JayPanoz
Correct AccessibleDfa name (bug #35)
bc52b6d
@JayPanoz
Copy link
Collaborator

JayPanoz commented Mar 5, 2018

Ah thanks, good catch. It’s been corrected on the alpha branch. 👍

@danielweck
Copy link
Member Author

This is fixed in master, right?

@JayPanoz
Copy link
Collaborator

Yes. I can confirm it should be fixed in the master branch now.

But maybe you want to align on the file itself i.e. AccessibleDfA?

@danielweck
Copy link
Member Author

I'm in favour of consistency, so if you want you may indeed use AccessibleDfA everywhere (i.e. filename, font-face declaration + font-family CSS property)
:)

@JayPanoz JayPanoz added the low-hanging fruit Issues you can tackle as your first code contribution label May 1, 2018
JayPanoz added a commit that referenced this issue May 2, 2018
@JayPanoz
Fix AccessibleDFA discrepancy #35
4f53b50
@JayPanoz
Copy link
Collaborator

JayPanoz commented May 2, 2018

It’s now fixed in the develop branch.

@JayPanoz JayPanoz removed the low-hanging fruit Issues you can tackle as your first code contribution label May 2, 2018
JayPanoz added a commit that referenced this issue May 7, 2018
@JayPanoz
Merge pull request #47 from readium/develop
64f6cc5 
Fix issue #35: font name disrepancy
@JayPanoz
Copy link
Collaborator

JayPanoz commented May 7, 2018

Is now on master, closing this issue.

@JayPanoz JayPanoz closed this as completed May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielweck @JayPanoz