Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPF metadata parsing (otherMetadata) #100

Closed
danielweck opened this issue Apr 24, 2019 · 3 comments · Fixed by readium/r2-streamer-swift#105
Closed

OPF metadata parsing (otherMetadata) #100

danielweck opened this issue Apr 24, 2019 · 3 comments · Fixed by readium/r2-streamer-swift#105
Assignees

Comments

@danielweck
Copy link
Member

The current parsing code hard-codes support for dc:source and dc:rights, but there are many other possibilities such as cc:attributionURL (<package prefix="cc: http://creativecommons.org/ns#">), a11y:certifiedBy ( http://www.idpf.org/epub/vocab/package/a11y/# ), dcterms:conformsTo, schema:accessModeSufficient, etc.

Any <meta property="NAME">VALUE</meta> or <meta name="NAME" value="VALUE"> not "natively" supported should be passed to otherMetadata, without hard-coding particular names.

https://github.com/readium/r2-streamer-swift/blob/1cc6dc1c683b12592b052c80669302f9c36efcdd/Sources/parser/EPUB/OPFParser.swift#L89-L93

@danielweck
Copy link
Member Author

Related issue: readium/r2-shared-js#16

@danielweck
Copy link
Member Author

Regarding dc:source and dc:rights, see: readium/webpub-manifest#14

@mickael-menu-mantano
Copy link
Contributor

readium/r2-streamer-swift#105 fixes this partially. <meta property="x"/> are added to otherMetadata, but dc:source and dc:rights are still hard-coded because they can appear like that: <dc:rights>Public domain</dc:rights>. Additional discussion regarding this can be found here: readium/webpub-manifest#14 (comment)

@mickael-menu mickael-menu transferred this issue from readium/r2-streamer-swift Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants