Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build updates! #188

Merged
merged 10 commits into from
Nov 8, 2022
Merged

Build updates! #188

merged 10 commits into from
Nov 8, 2022

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Oct 27, 2022

This update also contains #169

  • Update to latest Sphinx w/ docutils 0.17.1
  • Update to latest ablog, lxml
  • Remove transient dependencies from requirements.txt
  • fail on warnings.
  • Fix some broken intersphinx refs.
  • Apply styles for several elements in docutils 0.17
  • Shuffle around some margins, TBC in Adjust margins #191

Before:

image

After:

image

…intersphinx. Apply styles for ablog that aligns headers with post ul list.
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure about the CSS changes, since it's not my topic, but they look 👍🏼

cc'ing @agjohnson just in case he wants to review it.

@benjaoming benjaoming mentioned this pull request Nov 8, 2022
@benjaoming
Copy link
Contributor Author

What this PR mainly changes is margins, but it also re-aligns "Recent posts" with contents below it, which I think is nicer for the eye.

I've opened #191 to re-address margins.

@benjaoming
Copy link
Contributor Author

I went back to very old blog posts and they still look good:

https://readthedocs-blog--188.org.readthedocs.build/new-theme-read-the-docs/
https://readthedocs-blog--188.org.readthedocs.build/read-the-docs-2013-stats/

...however, I found an issue with unorderd lists that are missing bullets. Probably a DOM change.

Adding more styles...

@benjaoming
Copy link
Contributor Author

These are some good exercises for understanding what effort went into maintaining sphinx-theme-rtd 🥲

@benjaoming
Copy link
Contributor Author

I've been clicking around on a lot of blog posts now and stopped noticing things that look wrong.

So I think we're good to ship this.

It's supporting docutils 0.17 btw.

@agjohnson
Copy link
Contributor

Just noting that we don't plan to continue using our blog here. Our blog will be contained in our website repository, so spending much time here fixing things up is not a priority.

We don't have a timeframe, and need to consider if/how we port content:

readthedocs/website#33

@benjaoming
Copy link
Contributor Author

Ah yes, that's much better than the current blog. I wasn't aware. I'll wrap up the footnotes issue 👍

Love the issue description over in readthedocs/website#33 ❤️

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaoming
Copy link
Contributor Author

Replaced the floating CSS in footnotes with display: table, looks fine in Chrome and Firefox.

image

@benjaoming benjaoming merged commit d89c557 into main Nov 8, 2022
@benjaoming benjaoming deleted the build-updates branch November 8, 2022 22:39
benjaoming added a commit that referenced this pull request Nov 10, 2022
@benjaoming benjaoming mentioned this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants