Automate repo label syncing #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses readthedocs/readthedocs.org#4180 Also is the foundation for better autochangelog
|
Already did a pass on rtfd/redirect, went smoothly. Also tested against a live repo of mine really quick. |
humitos
approved these changes
Jun 8, 2018
| found = existing_label | ||
| break | ||
| if not found: | ||
| for existing_label in existing_labels: |
There was a problem hiding this comment.
I think you can simplify this by doing existing_label.name in ([label.name] + label.transpose) instead of having two loops.
There was a problem hiding this comment.
The reason it is this way is to provide precedence to existing labels before it tries any transposed labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automates all the github label pieces so that our labels are the same across
any of our repos. New labels are from
readthedocs/readthedocs.org#4180
Also is the foundation for better autochangelog, using pygithub directly