Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix tests #127

Merged
merged 9 commits into from
Jan 24, 2023
Merged

CI: fix tests #127

merged 9 commits into from
Jan 24, 2023

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 23, 2023 •
edited
Loading

  • The latest version of tox was being installed, but there is a bug when expanding enviroment names
  • The Python 3.6 image was giving an error, I guess because it's deprecated? I think we should be fine removing it from our test matrix
  • Test python 3.11 (updating sphinx-js was required)
  • Sphinx 6.x doesn't include jquery, so I'm using the suggestion about conditionally using jQuery from Support sphinx 6.0+ #126 (comment) for now
  • Test with sphinx 5 and 6.

@stsewd stsewd changed the title CI: fix tox CI: fix tests Jan 23, 2023
@stsewd stsewd marked this pull request as ready for review January 23, 2023 19:21
@stsewd stsewd requested a review from agjohnson January 23, 2023 19:21
@stsewd stsewd merged commit 5432999 into main Jan 24, 2023
@stsewd stsewd deleted the fix-tox branch January 24, 2023 20:52
@stsewd stsewd mentioned this pull request Jan 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @agjohnson