Site URLs should be configurable

[msiebuhr]

I'm trying to set up a RTFD-site internally in my company to host our documentation, but I'm struggling a bit with readthedocs.org (36) and, to a lesser extent, rtfd.org (3) being hard-coded all over the place.

IMHO, this should be configurable, somehow.

(I tried hacking it by adding a variable in readthedocs/settings/base.py, and accessing that in the templates, expecting it to "just work" like SITE_ROOT and friends, but to no avail. Any pointers to where I'm going wrong?)

[msiebuhr]

This has apparently been fixed by e7f9991, but I haven't had the time to verify this yet.

[dcolish]

I've begun to build urls using the {% url %} tag. That will ensure that the mentioned site settings are preserved.

[ericholscher]

Yea. Things originally used the url tags, but it caused some oddities with 404 pages on subdomains and CNAME'd pages. Basically, you would get .readthedocs.org/search or /login, which is another broken link, so it made it really hard to get back to the main site without manipulating the URLs.

I haven't thought of a great way to handle this, but keeping it working for local dev is probably more important ATM than having 404 pages work correctly, especially now that a lot of the 404s will come from nginx directly.

[ericholscher]

Closing this since it's done.