Build: fail PDF command (latexmk) if exit code != 0
#10113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were forcing `exit_code=0` if we detected that `Output written on (.*?)` was found in the standard output of the `latexmk` command. This was producing confusions to our users because the PDF generation failed but we were considering it successful. Now, we are relying on the exit code itself as we do for all the other commands making sure the command succeeded before proceding with the build. Now, if the PDF command fails, we fail the build completely.
stsewd
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
I'm +1 with this change. @ericholscher may want to review this as well.
ericholscher
approved these changes
Mar 6, 2023
I wrote a simple and quick proposal for the message. I'm not happy with it tho 😅 . Please, suggest a better option if you have something in mind. This is how this page will look like:
|
ericholscher
approved these changes
Mar 7, 2023
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
humitos
commented
Mar 7, 2023
This was referenced Mar 14, 2023
ericholscher
added a commit
that referenced
this pull request
Mar 16, 2023
ericholscher
added a commit
that referenced
this pull request
Mar 16, 2023
ericholscher
added a commit
that referenced
this pull request
Mar 16, 2023
ericholscher
added a commit
that referenced
this pull request
Mar 16, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were forcing
exit_code=0if we detected thatOutput written on (.*?)was found in the standard output of thelatexmkcommand. This was producing confusions to our users because the PDF generation failed but we were considering it successful.Now, we are relying on the exit code itself as we do for all the other commands making sure the command succeeded before proceding with the build. Now, if the PDF command fails, we fail the build completely.
Closes #10015