Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: fail PDF command (latexmk) if exit code != 0 #10113

Merged
merged 5 commits into from
Mar 7, 2023

Commits on Mar 6, 2023

  1. Build: fail PDF command (latexmk) if exit code != 0

    We were forcing `exit_code=0` if we detected that `Output written on (.*?)` was
    found in the standard output of the `latexmk` command. This was producing
    confusions to our users because the PDF generation failed but we were
    considering it successful.
    
    Now, we are relying on the exit code itself as we do for all the other commands
    making sure the command succeeded before proceding with the build. Now, if the PDF
    command fails, we fail the build completely.
    humitos committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    a2218b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    994430f View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Configuration menu
    Copy the full SHA
    2a2870b View commit details
    Browse the repository at this point in the history
  2. Better user message

    Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
    humitos and ericholscher authored Mar 7, 2023
    Configuration menu
    Copy the full SHA
    492c467 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9027fd0 View commit details
    Browse the repository at this point in the history