Fix git

[ericholscher]

No description provided.

[ericholscher]

On prod:

(docs)docs@build03:~/checkouts/readthedocs.org/user_builds/pip/checkouts/latest$ git --version
git version 1.9.1

(docs)docs@build03:~/checkouts/readthedocs.org/user_builds/pip/checkouts/latest$ git for-each-ref --format=%(if)%(*objectname)%(then)%(*objectname)%(else)%(objectname)%(end) %(refname) refs/tags
-bash: syntax error near unexpected token `('

(docs)docs@build03:~/checkouts/readthedocs.org/user_builds/pip/checkouts/latest$ git for-each-ref --format="%(if)%(*objectname)%(then)%(*objectname)%(else)%(objectname)%(end) %(refname)" refs/tags
fatal: unknown field name: if

[techtonik]

Maybe upgrade git?

$ git --version
git version 2.14.1

[safwanrahman]

Can we use gitpython?
http://gitpython.readthedocs.io/en/stable/

[ericholscher]

Yea, our entire VCS backend needs a lot more work and testing.

[humitos]

@ericholscher I have the same behaviour that the one you mentioned here in my computer

[humitos@julia:poliastro|master]$ git for-each-ref --format=%(if)%(*objectname)%(then)%(*objectname)%(else)%(objectname)%(end) %(refname) refs/tags
bash: error sintáctico cerca del elemento inesperado `('
[humitos@julia:poliastro|master]$ git version
git version 2.15.1
[humitos@julia:poliastro|master]$ 

but it seems that the way we are executing that command from inside the RTD code automatically escapes it or something since I found this issue by running the command with RTD.

[techtonik]

@humitos quotes are needed, because %(refname) is a part of format parameter.

[techtonik]

@ericholscher so, Edit bug is back? What about upgrading git requirement to 2.x?

[humitos]

"Edit in Github" for annotated tags bug (#3302) is back. The rest should work without any problem.

[techtonik]

Why it is not possible to just update git version on server to 2.x?

[humitos]

Upgrading the git version in the server doesn't fix the issue, does it?

[techtonik]

It does. Both commands that were run by @ericholscher on prod fail, but this one (with quotes around format string) fails because of old git version (1.9.1):

(docs)docs@build03:~/checkouts/readthedocs.org/user_builds/pip/checkouts/latest$ git for-each-ref --format="%(if)%(*objectname)%(then)%(*objectname)%(else)%(objectname)%(end) %(refname)" refs/tags
fatal: unknown field name: if

Try it on your system with git 2.x:

git for-each-ref --format="%(if)%(*objectname)%(then)%(*objectname)%(else)%(objectname)%(end) %(refname)" refs/tags

[humitos]

Yes. It works in my system from the terminal but it doesn't work when that command is ran by the RTD code. It seems there is something wrong when scapping the quotes El 1 ene. 2018 2:09 a. m., "anatoly techtonik" <notifications@github.com> escribió:

…

It does. Both commands that were run by @ericholscher <https://github.com/ericholscher> on prod fail, but this one (with quotes around format string) fails because of old git version (1.9.1): ***@***.***:~/checkouts/readthedocs.org/user_builds/pip/checkouts/latest$ git for-each-ref --format="%(if)%(*objectname)%(then)%(*objectname)%(else)%(objectname)%(end) %(refname)" refs/tags fatal: unknown field name: if Try it on your system with git 2.x: git for-each-ref --format="%(if)%(*objectname)%(then)%(*objectname)%(else)%(objectname)%(end) %(refname)" refs/tags — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3441 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAO7sOnx0EvDd2P4qoF8nAZzCUBMtoGkks5tGITAgaJpZM4RK2dT> .

[techtonik]

I see. Need to modify tests to actually run git over RTD sources. I feel like unit test code is a wrong place for external calls. Is there a better place for it?