Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adding RTD prefix for docker only in setting.py and all… #6315

Merged
merged 1 commit into from Oct 22, 2019

Conversation

@humitos
Copy link
Member

humitos commented Oct 21, 2019

Reverts #6040

This is causing some troubles in production. See #6308

… places where is needed"
@humitos humitos requested a review from readthedocs/core Oct 21, 2019
Copy link
Member

ericholscher left a comment

Agreed on moving slower with refactoring settings. We really need to think properly about how to time and schedule all of this, and just changing things without a backwards compatibility story will likely cause a mess either with us or for downstream users.

@ericholscher

This comment has been minimized.

Copy link
Member

ericholscher commented Oct 21, 2019

Travis error seems like a random eslint error.

@ericholscher

This comment has been minimized.

Copy link
Member

ericholscher commented Oct 21, 2019

Travis error seems like a random eslint error, and this doesn't change any JS files, so I think it's probably fine to merge.

@humitos humitos changed the title Revert "Adding RTD prefix for docker only in setting.py and all other places where is needed" Revert "Adding RTD prefix for docker only in setting.py and all… Oct 22, 2019
@humitos humitos merged commit 03971d7 into master Oct 22, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@humitos humitos deleted the revert-6040-adding_rtd_prefix branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.