Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Adding RTD prefix for docker only in setting.py and all… #6315

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Revert "Adding RTD prefix for docker only in setting.py and all… #6315

merged 1 commit into from
Oct 22, 2019

Conversation

humitos
Copy link
Member

@humitos humitos commented Oct 21, 2019

Reverts #6040

This is causing some troubles in production. See #6308

@humitos humitos requested a review from a team October 21, 2019 15:20
ericholscher
ericholscher approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on moving slower with refactoring settings. We really need to think properly about how to time and schedule all of this, and just changing things without a backwards compatibility story will likely cause a mess either with us or for downstream users.

@ericholscher
Copy link
Member

Travis error seems like a random eslint error.

@ericholscher
Copy link
Member

Travis error seems like a random eslint error, and this doesn't change any JS files, so I think it's probably fine to merge.

@humitos humitos changed the title Revert "Adding RTD prefix for docker only in setting.py and all other places where is needed" Revert "Adding RTD prefix for docker only in setting.py and all… Oct 22, 2019
@humitos humitos merged commit 03971d7 into master Oct 22, 2019
@humitos humitos deleted the revert-6040-adding_rtd_prefix branch October 22, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @ericholscher