-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update celery requirements to its latest version #6448
Conversation
Upgrading celery requires to upgrade their dependencies as well (kombu, redis). By using their latest version, it could help with the random disconnection of the workers that we suffer sometimes. After upgrading them all, the errors we have found when we pinned the versions they all disappeared.
Did you test with Also, this will closes #4643 |
Yes. All tests are ran with |
The error happens when triggering a build, I don't think it was detected inside the tests. |
Confirm. Triggering a build does work. |
So, the issue on celery is still open celery/celery#5330 But I think we don't use this anymore
That's why we don't hit this issue anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking we might still hit this in production, but I'm 👍 on trying to upgrade it, because falling super far behind on versions isn't good.
Let's merge this after our deploy today, so we have time to test it out in dev across different environments before we ship it to prod over the holidays. |
Upgrading celery requires to upgrade their dependencies as
well (kombu, redis). By using their latest version, it could help with
the random disconnection of the workers that we suffer sometimes.
After upgrading them all, the errors we have found when we pinned the
versions they all disappeared.
Closes #4643