-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default python version per Docker image #6653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of always picking the latest minor version when the user just put '2' or '3' in their YAML file, we use a default Python version per Docker image. This allows us to upgrade our Docker images (`latest` or `stable`) introducing new versions of Python (like `3.8`) without forcing users without specifying a Python version to use the new Python version. We can easily change the `default_version` in our `latest` or `stable` image when we the new Python version gets more stable and we know we won't affect too many users with the change.
ericholscher
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a small change.
davidfischer
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always picking the latest minor version when the user just put '2' or '3' in their YAML file, we use a default Python version per Docker image.
This allows us to upgrade our Docker images (
latest
orstable
) introducing new versions of Python (like3.8
) without forcing users without specifying a Python version to use the new Python version.We can easily change the
default_version
in ourlatest
orstable
image when we the new Python version gets more stable and we know we won't affect too many users with the change.Related #6324