Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default python version per Docker image #6653

Merged
merged 5 commits into from Feb 17, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 13, 2020

Instead of always picking the latest minor version when the user just put '2' or '3' in their YAML file, we use a default Python version per Docker image.

This allows us to upgrade our Docker images (latest or stable) introducing new versions of Python (like 3.8) without forcing users without specifying a Python version to use the new Python version.

We can easily change the default_version in our latest or stable image when we the new Python version gets more stable and we know we won't affect too many users with the change.

We can release a 6.0 (plus testing) Docker image from current master after this gets merged and deployed. We need to create another PR to add this value into the Docker setting, though. See #6654

Related #6324

humitos added 2 commits Feb 12, 2020
Instead of always picking the latest minor version when the user just
put '2' or '3' in their YAML file, we use a default Python version per
Docker image.

This allows us to upgrade our Docker images (`latest` or `stable`)
introducing new versions of Python (like `3.8`) without forcing users
without specifying a Python version to use the new Python version.

We can easily change the `default_version` in our `latest` or `stable`
image when we the new Python version gets more stable and we know we
won't affect too many users with the change.
Copy link
Member

@ericholscher ericholscher left a comment

Looks good with a small change.

readthedocs/config/config.py Outdated Show resolved Hide resolved
Copy link
Contributor

@davidfischer davidfischer left a comment

This looks good and makes sense.

@ericholscher ericholscher merged commit b1a2da3 into master Feb 17, 2020
3 checks passed
@ericholscher ericholscher deleted the humitos/default-python-version branch Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants