Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-999] Fix mesh compression settings #295

Closed
wants to merge 23 commits into from
Closed

[SDK-999] Fix mesh compression settings #295

wants to merge 23 commits into from

Conversation

HarrisonHough
Copy link
Collaborator

TICKETID

Description

  • This PR addresses the folllowing issues
    • the two settings are not compatible with each other. EG if 1 is enabled then the other can not be (it causes issues) So we should make it so that if 1 is enabled the other is automatically set to false (if it isn’t already)
    • Currently they can’t be toggled off. there seems to be an issue that once the plugins are installed they can’t be disabled. we need to fix that

How to Test

  • Add steps to locally test these changes

Checklist

  • Tests written or updated for the changes.
  • Documentation is updated.
  • Changelog is updated.

rk132 and others added 23 commits June 3, 2024 12:27
@rk132
feat: add cancellationTokens to requests
fa2d94a
@rk132
feat: update elements to cancel requests, when they are destroyed
1783fe1
@rk132
chore: apply suggestions
e130d88
@rk132
Feature/add cancellation tokens (#285)
0c75bd6 
## [SDK-971](https://ready-player-me.atlassian.net/browse/SDK-971)

## Description

- Update methods to throw an error, when cancellationToken was called,
and handle them in the Elements scene





[SDK-971]:
https://ready-player-me.atlassian.net/browse/SDK-971?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@HarrisonHough
chore: add unique name to template buttons
cd3b34a
@rk132
feat: refactor avatar creator scene
5b6532f
@rk132
chore: add bodytype to settings page
d0701ac
@rk132
chore: add editorWindows for bodyTypes
89b67e8
@HarrisonHough
Merge branch 'release/v6.3.0' into develop
05c17b5
@rk132
feat: refactor avatar creator scene (#289)
50a6adf 
## [SDK-968](https://ready-player-me.atlassian.net/browse/SDK-968)

## Description

- Refactor avatar creator elements scene and separate avatar management
from simple avatar creator script

[SDK-968]:
https://ready-player-me.atlassian.net/browse/SDK-968?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@rk132
feat: fix cancellation in wizard cac
63098df
@rk132
chore: refactor tests
155a9bd
@rk132
feat: update elements cac
2bd95b0
@rk132
Merge branch 'develop' into feature/move-bodytype-to-settings
89a8904
@rk132
chore: update avatar creators to use new bodytype parameter
956d74d
@rk132
feat: add avatarMetadata to animator helper
926038f
@rk132
chore: change object comparison to string comparison
dbc18cc
@rk132
Merge branch 'develop' into feature/fix-e2e-tests
4baf9c9
@rk132
Feature/fix e2e tests (#291)
f8c17b2 
<!-- Copy the TICKETID for this task from Jira and add it to the PR name
in brackets -->
<!-- PR name should look like: [TICKETID] My Pull Request -->

<!-- Add link for the ticket here editing the TICKETID-->

## [TICKETID](https://ready-player-me.atlassian.net/browse/TICKETID)

## Description

-   Briefly describe what this change will do

<!-- Fill the section below with Added, Updated and Removed information.
-->
<!-- If there is no item under one of the lists remove it's title. -->

<!-- Testability -->

## How to Test

-   Add steps to locally test these changes

<!-- Update your progress with the task here -->

## Checklist

-   [ ] Tests written or updated for the changes.
-   [ ] Documentation is updated.
-   [ ] Changelog is updated.

<!--- Remember to copy the Changes Section into the commit message when
you close the PR -->
@rk132
chore: apply suggestions
12f55a1
@rk132
[SDK-984] - move bodytype to settings (#290)
dcf3ed6 
## [SDK-984](https://ready-player-me.atlassian.net/browse/SDK-984)


![image](https://github.com/readyplayerme/rpm-unity-sdk-core/assets/107070960/19bf908c-bda5-48be-9950-bae5f5c3827b)


## Description

- Bodytype is moved to the settings page and removed from
configurations. This means, that users don't need to set it manually
everywhere.





[SDK-984]:
https://ready-player-me.atlassian.net/browse/SDK-984?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@HarrisonHough
fix: allow disable of compression
5839aa2
@HarrisonHough
fix: prevent using both compression types
9bb362c
@HarrisonHough HarrisonHough requested a review from a team as a code owner June 17, 2024 07:34
rk132
rk132 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@rk132 rk132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but merge to the hotfix branch instead of develop

@HarrisonHough HarrisonHough changed the base branch from develop to hotfix/fix-cache-loading June 17, 2024 10:44
@HarrisonHough HarrisonHough deleted the feature/bug-test branch June 17, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rk132 rk132 rk132 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarrisonHough @rk132