Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(animation): Act 992 nova animation transition fix #99

Merged
merged 9 commits into from
Sep 26, 2024
Merged

fix(animation): Act 992 nova animation transition fix #99

merged 9 commits into from
Sep 26, 2024

Conversation

Jarvv
Copy link
Contributor

@Jarvv Jarvv commented Sep 25, 2024 •
edited
Loading

MultipleAnimationModel changes:

  • Introduced animationTimeRef - on modelSrc change, the animation will continue playing from the same place
  • On active animation change, same logic will still apply as before, added extra check on prev action to prevent re-renders interrupting/resetting the animation

Ticket with videos:
https://ready-player-me.atlassian.net/jira/software/c/projects/ACT/boards/46?selectedIssue=ACT-992

@Jarvv Jarvv changed the title Act 992 animation transition fix fix(animation): Act 992 nova animation transition fix Sep 25, 2024
@Jarvv Jarvv marked this pull request as ready for review September 26, 2024 08:34
@Jarvv Jarvv requested a review from a team as a code owner September 26, 2024 08:34
@dan-rpm dan-rpm self-requested a review September 26, 2024 10:14
@Jarvv
Squashed commit of the following:
465b481 
commit 4797c19
Author: James Harvey <james.harvey@readyplayer.me>
Date:   Tue Sep 24 11:26:58 2024 +0100

    feat(emissive): ACT-972 material config

commit 628378a
Author: James Harvey <james.harvey@readyplayer.me>
Date:   Tue Sep 17 18:19:21 2024 +0300

    fix(emissive): ACT-972 fix emissive intensity
@Jarvv
Revert "Squashed commit of the following:"
c06ad60 
This reverts commit 465b481.
@Jarvv
Merge branch 'main' into ACT-992-animation-transition-fix
c696f30
@Jarvv Jarvv merged commit 37a4846 into main Sep 26, 2024
3 checks passed
@Jarvv Jarvv deleted the ACT-992-animation-transition-fix branch September 26, 2024 10:46
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-rpm dan-rpm dan-rpm approved these changes

@ericjansenrpm ericjansenrpm ericjansenrpm approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jarvv @dan-rpm @ericjansenrpm