New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Correctly load system properties in SystemUtil #164

Merged

mjpt777 merged 1 commit into real-logic:master from hsrinara:bug/systemprop

Jan 30, 2019

Contributor

hsrinara commented Jan 30, 2019

This PR changes the behaviour for SystemUtil.loadPropertiesFile so that system properties are correctly loaded.

I've also added a couple of tests

one which documents the behaviour for loadProperties
another which documents how properties are merged between systemprops and props from a file.


          Correctly load system properties in SystemUtil

832df4f

hsrinara changed the title ~~Correctly load system properties in SystemUtil~~ [Java] Correctly load system properties in SystemUtil

Contributor

mjpt777 commented Jan 30, 2019

This PR breaks the build by failing checkstyle. Please run a full build and fix.

mjpt777 merged commit b4951af into real-logic:master

mjpt777 added a commit that referenced this pull request


          [Java] Fix build and tidy up after merge of PR #164.

913e02b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet