-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OSGi support #176
Add OSGi support #176
Conversation
This change moves to using the biz.aQute.bnd Gradle plugin to produce OSGi-compatible manifests in jar files. Currently, only the org.agrona.core module has been updated to provide OSGi metadata because the Agrona agent should never need to be visible inside an OSGi container. Care has been taken to preserve the existing defined manifest fields (Automatic-Module-Name, Implementation-Title, etc).
This switches to using commands from Bnd that attempt to provide a reproducible manifest, rather than manually removing properties. Thanks @bjhargrave
I think |
what does this mean for the manifest in the normal Jar? |
I've preserved the properties you were using in the jar and this adds extra OSGi headers on top. This was your old jar manifest (agrona 1.0.3):
This is the manifest now:
All of these properties are ignored by anything that isn't either an OSGi tool, or an OSGi container. By publishing an |
Thanks. That makes sense. I'm merge when javadoc.io lets the tests complete. |
This change moves to using the biz.aQute.bnd Gradle plugin to
produce OSGi-compatible manifests in jar files. Currently, only the
org.agrona.core module has been updated to provide OSGi metadata
because the Agrona agent should never need to be visible inside an
OSGi container. Care has been taken to preserve the existing defined
manifest fields (Automatic-Module-Name, Implementation-Title, etc).