Demonstrate issue exceeding numInGroup in ControlNotification and avoid leaking offline sessions #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to support ticket: 18482. Session reconnections in `soleLibraryMode` cause `LiveLibraryInfo#allSessions` to grow, as offline sessions are not removed. Upon a library timeout and reconnection, the engine attempts to send details of these sessions to the library; however, that exceeds the maximum group size.
Relates to support ticket 18482. When using `soleLibraryMode` and a FIX session disconnects, the engine will keep the session instance in `LiveLibraryInfo` but mark it as disconnected (e.g., removing the endpoint information and `connectionId`). When a FIX session reconnects, a new session will be added to `LiveLibraryInfo` regardless of whether or not there is an existing session. In this commit, I've added a removal as part of `addSession` maintaining an invariant that `LiveLibraryInfo` has only one session instance per `sessionId`. I believe this is safe, but I'm not hugely familiar with lots of the code paths. I have added some logging in case I have missed something. There are some long standing checks around duplicate sessions, which gives me hope.
|
@ZachBray I use Intellij editor config from Aeron. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the commit messages for more details.
Note that this only fixes the group encoding exception when there are fewer than
uint8.MAX_VALUEsessions.We might want to introduce maximum session count limits too.
Apologies for the imports moving. Is there an IntelliJ Code Style file somewhere?