[Rust] Add derive Copy Clone traits for decoders #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreenPenguino
force-pushed
the
rust-decoder-copy-clone
branch
from
73b772a to
7082704
Compare
GreenPenguino
force-pushed
the
rust-decoder-copy-clone
branch
from
7082704 to
b8a0247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
CopyandClonetraits to message decoders.The Rust API guidelines recommend eagerly implementing common traits. Since decoders and the
ReadBufare views without mutable access into a read-only buffer, there is no harm in copying a decoder (if so, the Rust borrow checker would prevent it from compiling).