[Rust] Generation: Avoid warnings #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No clue why this failed 😓 Only Rust generation has changed. Is this an already failing test? @vyazelenko |
|
@YuhanunCitgez Try merging 0053ff3 commit into your branch. |
|
@vyazelenko Thanks, pushed. Let me know if there's anything I need to do to get this into stable, tried to follow CONTRIBUTING as far as I could hahaha |
|
@vyazelenko shall we merge? |
|
Not sure how to push ahead here. Pinging @vyazelenko and @mjpt777 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to avoid warnings that get generated because of some clippy flags.
We glob re-export the statics generated within the codecs, which causes issues due to duplicate naming.
In an ideal world, we would stop exporting the statics (or naming them uniquely), but for now I'd like to just avoid the warnings.
Additionally;
get_bytesis unused and unusable outside of the generated code itself, rendering it useless for any real-world project.