Couple of unrelated, but hopefully useful commits...

[mathomas]

• Allow extra libraries to cause a GF restart after installation. This is specifically useful when setting up a custom realm. The restart can be requested for specific libraries by specifying "requires_restart" in the library configuration hash (defaults to false, so can be omitted):

'extra_libraries' => {
    realm' => {
    'type' => 'common', 
    'url' => 'https://s3.amazonaws.com/my_bucket/myrealm.jar',
    'requires_restart' => true
}, . . .

• Comment-out what appears to be some sort of prior fix in domain.rb, but that actually borks deployment under Glassfish 4. This is mainly to start a conversation (and because I had pushed two commits and GitHub apparently doesn't let you cherry pick commits for pull requests ;-)).

[mathomas]

This block of code seems to be what perturbs GF at deployment time. At this point I don't know why it causes a deployment problem, but for me, if it's commented out I can deploy.

I also don't understand what the side-effect of NOT having this code is. So please treat this commit as a "conversation starter".

[realityforge]

I have manually merged in the changes to the LWRP. Thanks!

The other outstanding changes that I have yet to get to that you have submitted include the branches

• https://github.com/realityforge/chef-glassfish/tree/gf4_fix
• https://github.com/realityforge/chef-glassfish/tree/turn_off_ssl_for_admin

I will try to get to them soon but it needs a bunch of testing across our own infrastructure to see the impact.

Thanks again!

[mathomas]

No problem. Happy to contribute. The restart flag has been working well for me thus far. When I first added it I thought it would only be useful for custom realm libraries, but today I needed it when I added the mysql JAR file to a different GF project. It was the only extra JAR that I needed to include, and didn't think I needed the flag. Well, the deployment didn't work. I went and added the restart flag to that lib, and everything started fine.

Thanks for creating this thing. I'm happy to contribute in whatever small way I can.