Ensure service is started before asadmin command. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure this is a good thing to do. The provider only works if it runs immediately after the domain has been created which ensures it is running. If the domain is not running then this should also fail to run as starting up the server will likely result in it being in a bad state. There has been a plan to merge this command into the domain creation - see https://github.com/realityforge/chef-glassfish/blob/master/recipes/attribute_driven_domain.rb#L292 which would eliminate this whole failure scenario but never got around to fixing it. Thoughts? |
|
Closing this as not the way to address this issue. Feel free to open another issue to tackle the root cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.