Add explicit modules argument to makedocs #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't really testing anything: it's just a demonstration. Also, it appears that persisting definitions across code blocks only works for blocks of the same kind, so a julia block cannot share with a jldoctest block.
SentinelLimiter is careful to keep track of the expected type used to describe content lengths. The test was enforcing UInt64 lengths in the SentinelLimiter, but when run on a 32-bit system, sizeof(CONTENT) would return an Int32. Because the test was manually creating a Sentinel block by writing to an IO object with write(io, value), a 32-bit number was being written, but the SentinelLimiter was reading off a 64-bit number and reaching EOF too soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.