New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow Bundle() or Device() inits as they can be harmful #1306

Closed
Noobish1 opened this Issue Feb 14, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@Noobish1
Contributor

Noobish1 commented Feb 14, 2017

We ran into a couple of these recently and we wrote some custom rules to make sure we never have them in our codebase ever again. Not sure if it's worth having a rule for, just figured i'd see what everyone thought.

@jpsim jpsim added the rule-request label Feb 15, 2017

@jpsim

This comment has been minimized.

Show comment
Hide comment
@jpsim

jpsim Feb 15, 2017

Collaborator

Seems reasonable to me.

Collaborator

jpsim commented Feb 15, 2017

Seems reasonable to me.

ornithocoder added a commit to ornithocoder/personal-fork-swiftlint that referenced this issue Aug 1, 2017

ornithocoder added a commit to ornithocoder/personal-fork-swiftlint that referenced this issue Aug 1, 2017

ornithocoder added a commit to ornithocoder/personal-fork-swiftlint that referenced this issue Aug 1, 2017

@ornithocoder

This comment has been minimized.

Show comment
Hide comment
@ornithocoder

ornithocoder Aug 2, 2017

Contributor

@jpsim @marcelofabri issue can be closed :-)

Contributor

ornithocoder commented Aug 2, 2017

@jpsim @marcelofabri issue can be closed :-)

@jpsim jpsim closed this Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment