Force Unwrapping false positive

[ghost]

Declaring a local variable inside a function
var a: [Int]!
is considered force_unwrapping violation. But we are just defining an implicitly unwrapped optional and not force unwrapping it. Seems it is a false positive. It only occurs for Array type and not plain types. e.g. var a: Int! is not considered rule violation.

[JamieEdge]

Which version are you using?

I cannot reproduce this with the following example:

[ghost]

I'm currently using version 0.13.2

Please make sure to define the variable inside a function or method. For example:

func foo() { var x: [Int]! }

The force_unwrapping rule is an opt-in rule. So please also make sure it is opted in.

[marcelofabri]

I was able to reproduce it on master.

[JamieEdge]

Sorry, moved my test files but not the config! Can now reproduce the issue.

[marcelofabri]

I think this is actually a consequence of #136.

$ sourcekitten structure --text "func foo() { var x: [Int]! }"
{
  "key.substructure" : [
    {
      "key.kind" : "source.lang.swift.decl.function.free",
      "key.offset" : 0,
      "key.nameoffset" : 5,
      "key.namelength" : 5,
      "key.bodyoffset" : 12,
      "key.bodylength" : 15,
      "key.accessibility" : "source.lang.swift.accessibility.internal",
      "key.length" : 28,
      "key.name" : "foo()"
    }
  ],
  "key.offset" : 0,
  "key.diagnostic_stage" : "source.diagnostic.stage.swift.parse",
  "key.length" : 28
}

[marcelofabri]

Fixed in #1620.