Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make file_header rule ignore doc comments. #1730

Merged
merged 1 commit into from
Aug 1, 2017
Merged

Make file_header rule ignore doc comments. #1730

merged 1 commit into from
Aug 1, 2017

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1719

@marcelofabri marcelofabri requested a review from jpsim July 31, 2017 21:44
@marcelofabri marcelofabri mentioned this pull request Jul 31, 2017
Closed
jpsim
jpsim approved these changes Jul 31, 2017
View reviewed changes
Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Pending CI/OSSCheck results.

@SwiftLintBot
Copy link

SwiftLintBot commented Jul 31, 2017 •
edited
Loading

1 Warning
⚠️ Make sure that the docs are updated by running the Generate docs scheme.
57 Messages
📖 Linting Aerial with this PR took 0.35s vs 0.33s on master (6% slower)
📖 Linting Alamofire with this PR took 2.49s vs 2.4s on master (3% slower)
📖 Linting Firefox with this PR took 10.42s vs 10.51s on master (0% faster)
📖 Linting Kickstarter with this PR took 15.21s vs 15.7s on master (3% faster)
📖 Linting Moya with this PR took 0.71s vs 0.71s on master (0% slower)
📖 Linting Nimble with this PR took 1.37s vs 1.38s on master (0% faster)
📖 Linting Quick with this PR took 0.45s vs 0.46s on master (2% faster)
📖 This PR fixed a violation in Realm: /RealmSwift/Aliases.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Error.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /Realm/ObjectServerTests/SwiftSyncTestCase.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /Realm/ObjectServerTests/SwiftPermissionsAPITests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Migration.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/LinkingObjects.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /Realm/ObjectServerTests/SwiftObjectServerTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/List.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/ObjectiveCSupport.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/ObjectSchema.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Optional.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Property.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Object.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/RealmConfiguration.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Schema.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/SortDescriptor.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Realm.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Results.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/CompactionTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/RealmCollection.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Sync.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/KVOTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/ObjectAccessorTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/ObjectiveCSupportTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/ListTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/ObjectSchemaTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/ObjectSchemaInitializationTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/MigrationTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/PropertyTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/ObjectCreationTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/RealmConfigurationTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/PerformanceTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/ObjectTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/SchemaTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/SortDescriptorTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/SwiftLinkTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/SwiftUnicodeTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/TestCase.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/SwiftTestObjects.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/ThreadSafeReference.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Util.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /Realm/Swift/RLMSupport.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/ThreadSafeReferenceTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/RealmCollectionTypeTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/RealmTests.swift#L3:4: warning: File Header Violation: Header comments should be consistent with project patterns. (file_header)
📖 Linting Realm with this PR took 2.15s vs 2.2s on master (2% faster)
📖 Linting SourceKitten with this PR took 0.79s vs 0.81s on master (2% faster)
📖 Linting Sourcery with this PR took 3.62s vs 3.61s on master (0% slower)
📖 Linting Swift with this PR took 10.18s vs 10.2s on master (0% faster)
📖 Linting WordPress with this PR took 9.57s vs 9.57s on master (0% slower)

Generated by 🚫 Danger

@codecov-io
Copy link

codecov-io commented Jul 31, 2017 •
edited
Loading

Codecov Report

Merging #1730 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1730      +/-   ##
==========================================
+ Coverage   87.43%   87.47%   +0.04%     
==========================================
  Files         209      209              
  Lines       10335    10370      +35     
==========================================
+ Hits         9036     9071      +35     
  Misses       1299     1299
Impacted Files Coverage Δ
Tests/SwiftLintFrameworkTests/TestHelpers.swift 71.8% <100%> (+0.61%) ⬆️
...urce/SwiftLintFramework/Rules/FileHeaderRule.swift 96.72% <100%> (+0.11%) ⬆️
.../SwiftLintFrameworkTests/FileHeaderRuleTests.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f746f...d79f642. Read the comment docs.

@marcelofabri
Copy link
Collaborator Author

The Firefox violations shouldn't exist 🤔

@marcelofabri marcelofabri merged commit cca1060 into realm:master Aug 1, 2017
@marcelofabri marcelofabri deleted the bugfix-1719 branch August 1, 2017 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpsim jpsim jpsim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcelofabri @SwiftLintBot @codecov-io @jpsim