Treat conditional code as if it was always active #5581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
SimplyDanny
force-pushed
the
ignore-conditional-clauses
branch
from
77a26a3
to
686f371
Compare
|
I'd appreciate your feedback on this @mildm8nnered as you have provided the initial implementation of this rule. This is the last issue reported after the 0.55.0 release. Once it's merged, I may cut 0.55.1. |
| var varDecls = [VariableDeclSyntax]() | ||
|
|
||
| override func visitAny(_ node: Syntax) -> SyntaxVisitorContinueKind { | ||
| if node.isProtocol((any NamedDeclSyntax).self) { |
There was a problem hiding this comment.
ternary operator and save on the returns here potentially
SimplyDanny
commented
May 16, 2024
Source/SwiftLintBuiltInRules/Rules/Idiomatic/UnneededSynthesizedInitializerRule.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5574.