Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect comments before opening brace in opening_brace rule #5582

Merged
merged 1 commit into from
May 15, 2024

Conversation

SimplyDanny
Copy link
Collaborator

Fixes #5578.

@SwiftLintBot
Copy link

1 Warning
⚠️ This PR may need tests.
32 Messages
📖 Linting Aerial with this PR took 1.26s vs 1.25s on main (0% slower)
📖 Linting Alamofire with this PR took 1.79s vs 1.8s on main (0% faster)
📖 Linting Brave with this PR took 10.48s vs 10.48s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 5.55s vs 5.53s on main (0% slower)
📖 Linting Firefox with this PR took 13.79s vs 13.8s on main (0% faster)
📖 Linting Kickstarter with this PR took 12.7s vs 12.74s on main (0% faster)
📖 Linting Moya with this PR took 0.7s vs 0.7s on main (0% slower)
📖 Linting NetNewsWire with this PR took 3.71s vs 3.73s on main (0% faster)
📖 Linting Nimble with this PR took 1.03s vs 1.04s on main (0% faster)
📖 Linting PocketCasts with this PR took 10.35s vs 10.45s on main (0% faster)
📖 Linting Quick with this PR took 0.54s vs 0.54s on main (0% slower)
📖 Linting Realm with this PR took 6.36s vs 6.42s on main (0% faster)
📖 Linting Sourcery with this PR took 3.21s vs 3.2s on main (0% slower)
📖 Linting Swift with this PR took 6.36s vs 6.34s on main (0% slower)
📖 Linting VLC with this PR took 1.69s vs 1.69s on main (0% slower)
📖 Linting Wire with this PR took 23.88s vs 23.89s on main (0% faster)
📖 Linting WordPress with this PR took 15.92s vs 15.87s on main (0% slower)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Keyboard.swift:46:125: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/Playlist/Controllers/PlaylistViewController.swift:867:117: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/KeyPath.swift:2196:64: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/KeyPath.swift:2286:59: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/KeyPath.swift:2342:67: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/KeyPath.swift:2381:76: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Optional.swift:135:60: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Pointer.swift:116:37: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Pointer.swift:160:38: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Pointer.swift:233:37: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Pointer.swift:305:36: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Pointer.swift:318:56: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Pointer.swift:326:45: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Result.swift:24:58: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Services/MediaCoordinator.swift:858:69: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

Generated by 🚫 Danger

Copy link
Collaborator

@mildm8nnered mildm8nnered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SimplyDanny SimplyDanny merged commit dfe19ac into realm:main May 15, 2024
12 checks passed
@SimplyDanny SimplyDanny deleted the respect-comments branch May 15, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opening_brace triggers when the brace is preceded by a comment
3 participants