Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type inside shell script in README.md #5621

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Conversation

miltenkot
Copy link
Contributor

I notice wrong typo which doesn't works properly.

Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a typo in the original word. "Validation" is correct.

@miltenkot
Copy link
Contributor Author

I don't see a typo in the original word. "Validation" is correct.

Yes, however, does not work correctly. I checked with this article, and it should be entered with a misspelling (validataion) to work with CI (Xcode Cloud). (https://forums.swift.org/t/telling-xcode-14-beta-4-to-trust-build-tool-plugins-programatically/59305/10)

@SimplyDanny
Copy link
Collaborator

I don't see a typo in the original word. "Validation" is correct.

Yes, however, does not work correctly. I checked with this article, and it should be entered with a misspelling (validataion) to work with CI (Xcode Cloud). (https://forums.swift.org/t/telling-xcode-14-beta-4-to-trust-build-tool-plugins-programatically/59305/10)

I see, that wasn't obvious to me. It's still hard to approve a PR that introduces a typo ... I've never done that before. 😅

@SimplyDanny SimplyDanny linked an issue Jun 14, 2024 that may be closed by this pull request
Hey, I noticed that this command has an error and it should be typed like this to work properly.
@SimplyDanny SimplyDanny enabled auto-merge (squash) June 22, 2024 17:34
@SimplyDanny SimplyDanny merged commit 3b19e7d into realm:main Jun 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect setting name for package plugin validation in README.md
2 participants