-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unused import rule transitive dependencies #5622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulTaykalo
force-pushed
the
experiment/update-unused-import-rule
branch
2 times, most recently
from
June 12, 2024 07:20
b2fe17a
to
6f8a308
Compare
2 tasks
PaulTaykalo
force-pushed
the
experiment/update-unused-import-rule
branch
from
June 12, 2024 07:41
6f8a308
to
7e92f70
Compare
Naveen-C-Ramachandrappa
approved these changes
Sep 10, 2024
SimplyDanny
force-pushed
the
experiment/update-unused-import-rule
branch
2 times, most recently
from
September 10, 2024 21:51
dbec2d1
to
824f5df
Compare
Generated by 🚫 Danger |
SimplyDanny
force-pushed
the
experiment/update-unused-import-rule
branch
from
October 24, 2024 17:40
824f5df
to
023ab9a
Compare
SimplyDanny
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PaulTaykalo for the initial implementation!
I think this is good to be merged now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to resolve an issue, when unused import resolved incorrectly, since
swiflint
doesn't check transitive importsFor example, if we have
Cocoa module is actually
So this PR actually tries to account
transitive_modules
configuration to prevent incorrect import removalsAlternative
As an alternative we can try to generate interfaces of all imported modules (once per module)
And parse their imports on the top level
So , for example, if we found some missing modules, we'll check if those can be found in the generated interface.
For example,
Will allow to use any of the underlying modules
Related Issues:
#5167