Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore ACL restricted to setting in extension_access_modifier rule #5625

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

SimplyDanny
Copy link
Collaborator

Fixes #5623.

@SwiftLintBot
Copy link

1 Warning
⚠️ This PR introduced a violation in Wire: /wire-ios-data-model/Source/ManagedObjectContext/NSManagedObjectContext+AppLock.swift:21:1: warning: Extension Access Modifier Violation: Prefer to use extension access modifiers (extension_access_modifier)
17 Messages
📖 Linting Aerial with this PR took 1.26s vs 1.26s on main (0% slower)
📖 Linting Alamofire with this PR took 1.83s vs 1.8s on main (1% slower)
📖 Linting Brave with this PR took 10.5s vs 10.52s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 5.48s vs 5.48s on main (0% slower)
📖 Linting Firefox with this PR took 13.97s vs 14.03s on main (0% faster)
📖 Linting Kickstarter with this PR took 12.77s vs 12.81s on main (0% faster)
📖 Linting Moya with this PR took 0.69s vs 0.71s on main (2% faster)
📖 Linting NetNewsWire with this PR took 3.56s vs 3.57s on main (0% faster)
📖 Linting Nimble with this PR took 1.03s vs 1.04s on main (0% faster)
📖 Linting PocketCasts with this PR took 10.54s vs 10.53s on main (0% slower)
📖 Linting Quick with this PR took 0.54s vs 0.56s on main (3% faster)
📖 Linting Realm with this PR took 6.52s vs 6.57s on main (0% faster)
📖 Linting Sourcery with this PR took 3.23s vs 3.23s on main (0% slower)
📖 Linting Swift with this PR took 6.39s vs 6.36s on main (0% slower)
📖 Linting VLC with this PR took 1.71s vs 1.69s on main (1% slower)
📖 Linting Wire with this PR took 24.5s vs 24.51s on main (0% faster)
📖 Linting WordPress with this PR took 18.75s vs 18.74s on main (0% slower)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny merged commit 72069bf into realm:main Jun 22, 2024
12 checks passed
@SimplyDanny SimplyDanny deleted the ignore-setting-acl branch June 22, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive of extension_access_modifier on property with private(set)
2 participants