Link to markdown docs pages from index pages #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnfairh
force-pushed
the
jf-guide-index
branch
from
c149191
to
0a19173
Compare
|
Sorry it took me so long to review this, but this looks great! Feel free to merge after updating the integration specs. 👍 |
|
No problem; thanks - will try to remember how to drive this project. |
Some NFC prep for guides and doc structure work: Delete `readme_generator.rb` -- not used. Common up init code for index.html & guides. DRY the `document.markdown` magic text. Rename `SourceDecl.render?` to have clearer intent, refactor into class hierarchy. Delete unused `SourceDecl.type?`.
Minor theme changes to link directly to the document without a pop-open disclosure section.
johnfairh
force-pushed
the
jf-guide-index
branch
from
0a19173
to
06393a5
Compare
This was referenced Dec 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to docs pages from the Guides page (or wherever). Direct link to the page, no disclosure section.
I think this is generally useful, also feel we'll need it to make the sub-categories feature work properly.
First commit is refactoring to make this area clearer; second commit has the actual change. Looks a bit bigger than it is due to replicating css/template change between themes.
Specs update for css change plus an example of use in MiscJazzyFeatures.